Enable enqueuing updates for expired items when serving stale #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @simonbos thank you for that, it indeed looks like a miss, good catch. My tests weren't testing this scenario as well, it only checked if servestale worked, that too without an updater. I'll wait for your test cases update before merging. |
simonbos
force-pushed
the
enable-enqueueing-update-stale-expired
branch
from
8e8dff1 to
e15b7f9
Compare
|
Thanks! I confirmed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the logic behaves like the following when the
ServeStaleistrue.I adapted it to also enqueue an update in the expired after the second "threshold window".
Please let me know if the previous behavior was on purpose or if it was a bug. If it was not purpose, I will also create a test case.